Hi, Matthew, Thank you for your comments, On Fri, Apr 24, 2020 at 7:27 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Fri, Apr 24, 2020 at 04:29:04PM +0800, Huacai Chen wrote: > > MIPS define a "Fill" macro as a cache operation in cacheops.h, this > > will cause build failure under some special configurations. To avoid > > this failure we rename the "Fill" label in seq_file.c. > > You should rename the Fill macro in the mips header instead. > I'd suggest Fill_R4000 of R4000_Fill. Hi, Thomas, What do you think about this? If you agree to rename the "Fill" macro in cacheops.h, I want to rename it to Fill_I, because it has the same coding style as other cache operations in cacheops.h. Thanks, Huacai
