On Sat, 2008-08-09 at 08:47 -0400, Christoph Hellwig wrote: > On Thu, Aug 07, 2008 at 07:40:06PM +0800, Ian Kent wrote: > > Usage of the AUTOFS_TYPE_* defines is a little confusing and > > appears inconsistent. > > Not enough of an explanation for this patch. OK, I'll re-submit this with an updated description. > > It does: > > - move AUTOFS_TYPE_INDIRECT/AUTOFS_TYPE_DIRECT/AUTOFS_TYPE_OFFSET > to include/linux/auto_fs4.h. Obviously okay but should mentioned > in the changelog. So that user space can use consistent definitions. > - add a new, unused AUTOFS_TYPE_ANY constant. Why? It is used by the later ioctl implementation patch. > - add a new AUTOFS_TYPE_TRIGGER and use it instead of > AUTOFS_TYPE_DIRECT or in one single case > (AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET). Definitively needs a good > explanation. The direct and offset autofs mount types are, to a large extent, treated the same way in the kernel module but are used a little differently in user space. Previously, an offset mount had it's type set to AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET but, the subsequent ioctl implementation patch needs to be able to identify all three types of autofs mount distinctly. > - replaces one use of sbi->type = 0 with AUTOFS_TYPE_INDIRECT (0x0001). > Why? Previously, a type of 0 was implicitly assumed to be type AUTOFS_TYPE_INDIRECT but that was not clear and doesn't lend itself to clearly defined logic when trying to locate a specific type of autofs mount in the later patch in the series. Ian -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
