On Fri, 2008-08-08 at 13:44 +0200, Jens Axboe wrote: > + if (err) { > + if (err == -EOPNOTSUPP) > + set_bit(BIO_EOPNOTSUPP, &bio->bi_flags); > + clear_bit(BIO_UPTODATE, &bio->bi_flags); > + } If we're going to do that, we should do it whether the caller provides their own end_io function or not. So we should probably call their ->end_io function from ours. I'll store it in ->bi_private and do just that. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html