On Fri, 2008-08-08 at 08:22 -0600, Matthew Wilcox wrote: > If the current T10 and T13 proposals stand unmodified, it'll be a bit of a > pain to implement fully. PUNCH currently requires creating a data buffer > and attaching it to the command. When we get down into libata, we then > want to throw that data buffer away again because TRIM doesn't need a > data buffer (indeed to translate PUNCH to TRIM, we need to send a series > of commands because PUNCH allows you to specify a set of ranges whereas > TRIM only lets you send one range at a time). > > Let's hope T10 agrees that only one range is necessary at a time. Weird. Does it really make sense for us to be 'translating' from generic requests to SCSI and then from those to ATA? I hadn't realised our code was that baroque... -- David Woodhouse Open Source Technology Centre David.Woodhouse@xxxxxxxxx Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html