On 18/04/2020 18:02, Bart Van Assche wrote:
> How about adding __must_check to scsi_setup_fs_cmnd()?
I'm actually not sure if __must_check helps us anything given that with
this patch applied:
johannes@redsun60:linux(zone-append-wip)$ git --no-pager grep -n \
scsi_setup_fs_cmnd drivers/scsi
drivers/scsi/scsi_lib.c:1173:
static blk_status_t scsi_setup_fs_cmnd(struct scsi_device *sdev,
drivers/scsi/scsi_lib.c:1205:
ret = scsi_setup_fs_cmnd(sdev, req);
there's only one caller of scsi_setup_fs_cmnd(), in the same file, 32
lines below the implementation.
I do agree about the Link or an eventual Cc: stable, but I think Martin
or Jens can add this when applying the patch.
