> On 2020/04/17 11:39, Namjae Jeon wrote: > >> Replace "time_ms" with "time_cs" in the file directory entry > >> structure and related functions. > >> > >> The unit of create_time_ms/modify_time_ms in File Directory Entry are > >> not 'milli-second', but 'centi-second'. > >> The exfat specification uses the term '10ms', but instead use 'cs' as > >> in "msdos_fs.h". > >> > >> Signed-off-by: Tetsuhiro Kohada > >> <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > >> --- > > I have run checkpatch.pl on your patch. > > It give a following warning. > > > > WARNING: Missing Signed-off-by: line by nominal patch author > > 'Tetsuhiro Kohada <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx>' > > total: 0 errors, 1 warnings, 127 lines checked > > > > Please fix it. > > I want to fix it, but I'm not sure what's wrong. > The my patch has the following line: > > Signed-off-by: Tetsuhiro Kohada > <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Both my real name and email address are correct. > Can you give me some advice? Your address in author line of this patch seems to be different with Your Signed-off-by. From: Tetsuhiro Kohada <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> != Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> What is correct one between the two? I guess you should fix your mail address in your .gitconfig Or manually add From: your address under subject in your patch like this. ------------------------------------------------------------------------------- Subject: [PATCH v3] exfat: replace 'time_ms' with 'time_cs' From: Tetsuhiro Kohada <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Replace "time_ms" with "time_cs" in the file directory entry structure and related functions. The unit of create_time_ms/modify_time_ms in File Directory Entry are not 'milli-second', but 'centi-second'. The exfat specification uses the term '10ms', but instead use 'cs' as in "msdos_fs. Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> -------------------------------------------------------------------------------- > > *** Currently I can't use office email, so I'm sending it from private > email instead. > > > -- > このEメールはアバスト アンチウイルスによりウイルススキャンされています。 > https://www.avast.com/antivirus
