On Sun, Apr 19, 2020 at 12:51:21AM +0200, Guoqing Jiang wrote: > After the helper is exported, we can call it to simplify code a little. > > Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Cc: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > Cc: linux-xfs@xxxxxxxxxxxxxxx > Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx> > --- > fs/iomap/buffered-io.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 89e21961d1ad..b06568ad9a7a 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -74,9 +74,7 @@ iomap_page_release(struct page *page) > return; > WARN_ON_ONCE(atomic_read(&iop->read_count)); > WARN_ON_ONCE(atomic_read(&iop->write_count)); > - ClearPagePrivate(page); > - set_page_private(page, 0); > - put_page(page); > + __clear_page_buffers(page); We should not call a helper mentioning buffers in code that has nothing to do with buffers. If you want to us __clear_page_buffers more widely please give it a better name first. You'll also forgot to Cc me on the other patches in the series, which is a completel no-go as it doesn't allow for a proper review.
