On Fri, Apr 17, 2020 at 08:42:12AM +0000, Johannes Thumshirn wrote: > On 17/04/2020 09:42, Daniel Wagner wrote: > > Stupid question. At the end of this function I see: > > > > /* > > * If the host/device is unable to accept more work, inform the > > * caller of that. > > */ > > if (ret == BLK_STS_RESOURCE || ret == BLK_STS_DEV_RESOURCE) > > return false; > > > > Why is BLK_STS_ZONE_RESOURCE missing? > > Because technically the device can still accept more work, it is just > the zone-write lock for one (or more) zone(s) is locked. So we can still > try to dispatch work to the device, like reads or writes to other zones > in order to not starve any readers or writers to different zones. Okay thanks for explaining. As far as I can review it, it looks good. The code matches the commit message. Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>