Re: [PATCH v3 3/4] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Max Kellermann <mk@xxxxxxxxxx>
Subject: Re: [PATCH v3 3/4] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Apr 2020 00:51:50 -0700
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, trond.myklebust@xxxxxxxxxxxxxxx, bfields@xxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, agruenba@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20200407142243.2032-3-mk@cm4all.com>

> +#ifdef CONFIG_FS_POSIX_ACL
>  #define IS_POSIXACL(inode)	__IS_FLG(inode, SB_POSIXACL)
> +#else
> +#define IS_POSIXACL(inode)	0
> +#endif

Looks good, but I'd simplify this down to:

#define IS_POSIXACL(inode) \
	(IS_ENABLED(CONFIG_FS_POSIX_ACL) && __IS_FLG(inode, SB_POSIXACL))

References:
- [PATCH v3 1/4] fs/posix_acl: apply umask if superblock disables ACL support
  - From: Max Kellermann
- [PATCH v3 3/4] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n
  - From: Max Kellermann

Prev by Date: Re: [PATCH v3 2/4] fs/ext4/acl: apply umask if ACL support is disabled
Next by Date: Re: [PATCH v3 4/4] nfs/super: check NFS_CAP_ACLS instead of the NFS version
Previous by thread: [PATCH v3 3/4] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n
Next by thread: [PATCH v3 2/4] fs/ext4/acl: apply umask if ACL support is disabled
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux