> On Wednesday 08 April 2020 03:59:06 Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx wrote: > > > So partial_name_hash() like I used it in this patch series is enough? > > > > I think partial_name_hash() is enough for 8/16/21bit characters. > > Great! > > Al, could you please take this patch series? I think it's good. > > Another point about the discrimination of 21bit characters: > > I think that checking in exfat_toupper () can be more simplified. > > > > ex: return a < PLANE_SIZE && sbi->vol_utbl[a] ? sbi->vol_utbl[a] : a; > > I was thinking about it, but it needs more refactoring. Currently > exfat_toupper() is used on other places for UTF-16 (u16 array) and therefore it cannot be extended to take more then 16 > bit value. I’m also a little worried that exfat_toupper() is designed for only utf16. Currently, it is converting from utf8 to utf32 in some places, and from utf8 to utf16 in others. Another way would be to unify to utf16. > But I agree that this is another step which can be improved. Yes.
