On 2020-04-09 14:45, Luis Chamberlain wrote: > Ensure that the reqest_queue ref counts the request_queue ^^^^^^^^^^^^ ^^^^^^^^^^ request_queue? refcounts? > during its full ioctl cycle. This avoids possible races against > removal, given blk_get_queue() also checks to ensure the queue > is not dying. > > This small race is possible if you defer removal of the reqest_queue ^^^^^^^^^^^^ request_queue? > and userspace fires off an ioctl for the device in the meantime. Anyway: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>