On Mon, Apr 6, 2020 at 2:03 PM Christoph Hellwig <hch@xxxxxx> wrote: > > Replace the coredump ->read method with a ->dump method that must call > dump_emit itself. That way we avoid a buffer allocation an messing with > set_fs() to call into code that is intended to deal with user buffers. > For the ->get case we can now use a small on-stack buffer and avoid > memory allocations as well. I had no memory of this code at all, but your change looks fine to me. Amazingly you even managed to even make it smaller and more readable Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
