Michal Suchanek's on March 19, 2020 10:19 pm: > Less code means less bugs so add a knob to skip the compat stuff. > > Changes in v2: saner CONFIG_COMPAT ifdefs > Changes in v3: > - change llseek to 32bit instead of builing it unconditionally in fs > - clanup the makefile conditionals > - remove some ifdefs or convert to IS_DEFINED where possible > Changes in v4: > - cleanup is_32bit_task and current_is_64bit > - more makefile cleanup > Changes in v5: > - more current_is_64bit cleanup > - split off callchain.c 32bit and 64bit parts > Changes in v6: > - cleanup makefile after split > - consolidate read_user_stack_32 > - fix some checkpatch warnings > Changes in v7: > - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek > - remove leftover hunk > - add review tags > Changes in v8: > - consolidate valid_user_sp to fix it in the split callchain.c > - fix build errors/warnings with PPC64 !COMPAT and PPC32 > Changes in v9: > - remove current_is_64bit() > Chanegs in v10: > - rebase, sent together with the syscall cleanup > Changes in v11: > - rebase > - add MAINTAINERS pattern for ppc perf These all look good to me. I had some minor comment about one patch but not really a big deal and there were more cleanups on top of it, so I don't mind if it's merged as is. Actually I think we have a bit of stack reading fixes for 64s radix now (not a bug fix as such, but we don't need the hash fault logic in radix), so if I get around to that I can propose the changes in that series. Thanks, Nick