On Tue, Mar 31, 2020 at 01:42:08PM +0000, Wei Yang wrote: > On Mon, Mar 30, 2020 at 07:28:21AM -0700, Matthew Wilcox wrote: > >On Mon, Mar 30, 2020 at 02:15:58PM +0000, Wei Yang wrote: > >> On Mon, Mar 30, 2020 at 05:48:42AM -0700, Matthew Wilcox wrote: > >> >On Mon, Mar 30, 2020 at 12:36:39PM +0000, Wei Yang wrote: > >> >> If an entry is at the last level, whose parent's shift is 0, it is not > >> >> expected to be a node. We can just leverage the xa_is_node() check to > >> >> break the loop instead of check shift additionally. > >> > > >> >I know you didn't run the test suite after making this change. > >> > >> I did kernel build test, but not the test suite as you mentioned. > >> > >> Would you mind sharing some steps on using the test suite? And which case you > >> think would trigger the problem? > > > >cd tools/testing/radix-tree/; make; ./main > > > > Hmm... I did a make on top of 5.6-rc6, it failed. Would you mind taking a look > into this? It works for me. I run it almost every day. What error did you see?
