On Mon 30-03-20 13:42:03, Amir Goldstein wrote: > > > > Ah, right. Thanks for clarification. Actually, I think now that we have > > fanotify event 'type' notion, I'd like to make overflow event a separate > > type which will likely simplify a bunch of code (e.g. we get rid of a > > strange corner case of 'path' being included in the event but being > > actually invalid). Not sure whether I'll do it for this merge window, > > probably not since we're in a bit of a hurry. > > > > Jan, > > I went a head and did those 2 cleanups you suggested to > fanotify_alloc_event(). pushed result to fsnotify-fixes branch. > Probably no rush to get those into this merge window. > For your consideration. Thanks! Since the merge window is already open, I'd queue these fixes for the next merge window together with the remaining fanotify work... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR