On Tue, Mar 17, 2020 at 3:57 PM Christoph Hellwig <hch@xxxxxx> wrote: > > On Tue, Mar 03, 2020 at 02:42:50PM +0100, Andreas Gruenbacher wrote: > > Miklos, > > > > On Fri, Feb 21, 2020 at 7:01 PM Christoph Hellwig <hch@xxxxxx> wrote: > > > There is no excuse to ever perform actions related to a specific handler > > > directly from the generic xattr code as we have handler that understand > > > the specific data in given attrs. As a nice sideeffect this removes > > > tons of pointless boilerplate code. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > can you please review this change from an overlayfs point of view? > > ping? To me it looks like these need fixup: fs/overlayfs/dir.c: - err = posix_acl_to_xattr(&init_user_ns, acl, buffer, size); + err = posix_acl_to_xattr(current_user_ns(), acl, buffer, size); fs/overlayfs/super.c: - acl = posix_acl_from_xattr(&init_user_ns, value, size); + acl = posix_acl_from_xattr(current_user_ns(), value, size); Thanks, Miklos
