On Sun 08-03-20 09:29:08, Amir Goldstein wrote: > > To see what the benefit of inherit fanotify_fid_event is, I did a test patch > > to get rid of it and pushed the result to fanotify_name-wip: > > > > * b7eb8314c61b - fanotify: do not inherit fanotify_name_event from > > fanotify_fid_event > > > > IMO, the removal of inheritance in this struct is artificial and > > brings no benefit. > > There is not a single line of code that improved IMO vs. several added > > helpers which abstract something that is pretty obvious. > > > > That said, I don't mind going with this variant. > > Let me you what your final call is. > > > > Eventually, it was easier to work the non-inherited variant into the series > as the helpers aid with abstracting things as the series progresses and > because object_fh is added to fanotify_name_event late in the series. > So I went with your preference. > > Pushed the work to fanotify_name branch. > Let me know if you want me to post v3. So I went through the patches - had only minor comments for most of them. Can you post the next revision by email and I'll pickup at least the obvious preparatory patches to my tree. Thanks! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
