Re: [PATCH v5 1/3] mm, list_lru: make memcg visible to lru walker isolation function

[Yafang Shao <laoar.shao@xxxxxxxxx>]

On Mon, Mar 16, 2020 at 12:03 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Sun, Mar 15, 2020 at 05:53:40AM -0400, Yafang Shao wrote:
> > +#define for_each_mem_cgroup_tree(iter, root)         \
> > +     for (iter = mem_cgroup_iter(root, NULL, NULL);  \
> > +          iter != NULL;                              \
> > +          iter = mem_cgroup_iter(root, iter, NULL))
> [...]
> > +#define for_each_mem_cgroup_tree(iter)               \
> > +     for (iter = NULL; iter; )
> > +
>
> That's not the same signature ...

for_each_mem_cgroup_tree() isn't used when CONFIG_MEMCG is not set, so
should remove it.

Thanks for pointing it out!

-- 
Yafang Shao
DiDi