On Thu, Jul 31, 2008 at 01:41:58PM +0200, Miklos Szeredi wrote:
> On Thu, 31 Jul 2008, Al Viro wrote:
> > On Wed, Jul 30, 2008 at 03:02:03PM +0200, Miklos Szeredi wrote:
> > > static int coda_ioctl_permission(struct inode *inode, int mask)
> > > {
> > > - return 0;
> > > + return check_execute(dentry->d_inode, mask);
> > > }
> >
> > Er?
> > a) mismerge from dentry-based variant
>
> Yeah, crappy patch. Agree on all other comments as well, thanks for
> the review.
Hrm... OK, behaviour change for permission() on bdev/cdev/pipe is
not a problems...
I'll apply it, but if anybody has better suggestions for helper name,
please yell. "execute_ok()" sounds very odd...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
