KOSAKI Motohiro wrote:
>> *ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
>> - if (filp)
>> - file_accessed(filp);
>> + file_accessed(filp);
>> }
>>
>> int file_read_actor(read_descriptor_t *desc, struct page *page,
>
> if filp is never NULL, BUG_ON is better?
>
static inline void file_accessed(struct file *file)
{
if (!(file->f_flags & O_NOATIME))
...
}
So if filp is NULL, we'll get a noisy NULL dereference bug immediately,
so BUG_ON() is not needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
