David Howells <dhowells@xxxxxxxxxx> wrote: > Is ext4_dio_read_iter() broken? It calls: > > file_accessed(iocb->ki_filp); > > at the end of the function - but surely iocb should be expected to have been > freed when iocb->ki_complete() was called? I think it's actually worse than that. You also can't call inode_unlock_shared(inode) because you no longer own a ref on the inode since ->ki_complete() is expected to call fput() on iocb->ki_filp. Yes, you own a shared lock on it, but unless somewhere along the fput-dput-iput chain the inode lock is taken exclusively, the inode can be freed whilst you're still holding the lock. Oh - and ext4_dax_read_iter() is also similarly broken. And xfs_file_dio_aio_read() appears to be broken as it touches the inode after calling iomap_dio_rw() to unlock it. David
