On Tue, Mar 10, 2020 at 08:36:14PM -0700, Darrick J. Wong wrote: > There are still other things that need to be ironed out WRT pmem: > > a) reflink and page/pfn/whatever sharing -- fix the mm or (ab)use the > xfs buffer cache, or something worse? I don't think we need either. We just need to remove the DAX page association for hwpoison that requires the struct page to store the mapping and index. Get rid of that and we should be able to safely map the same page into different inode address spaces at the same time. When we write a shared page, we COW it immediately and replace the page in the inode's mapping tree, so we can't actually write to a shared page... IOWs, the dax_associate_page() related functionality probably needs to be a filesystem callout - part of the aops vector, I think, so that device dax can still use it. That way XFS can go it's own way, while ext4 and device dax can continue to use the existing mechanism mechanisn that is currently implemented.... XFS can then make use of rmapbt to find the owners on a bad page notification, and run the "kill userspace dead dead dead" lookup on each mapping/index tuple rather than pass it around on a struct page. i.e. we'll do a kill scan for each mapping/index owner tuple we find, not just one. That requires converting all the current vma killer code to pass mapping/index tuples around rather than the struct page. That kill code doesn't actually need the struct page, it just needs the mapping/index tuple to match to the vmas that have it mapped into userspace. > b) getting our stories straight on how to clear poison, and whether or > not we can come up with a better story for ZERO_FILE_RANGE on pmem. In > the ideal world I'd love to see Z_F_R actually memset(0) the pmem and > clear poison, at least if the file->pmem mappings were contiguous. Are you talking about ZFR from userspace through the filesystem (how do you clear poison in free space?) or ZFR on the dax device fro either userspace or the kernel filesystem code? > c) wiring up xfs to hwpoison, or wiring up hwpoison to xfs, or otherwise > figuring out how to get storage to tell xfs that it lost something so > that maybe xfs can fix it quickly Yup, I think that's a dax device callback into the filesystem. i.e the hwpoison gets delivered to the dax device, which then calls the fs function rather than do it's current "dax_lock_page(), kill userspace dead dead dead, dax_unlock_page()" dance. The filesystem can do a much more intricate dance and wreak far more havoc on userspace than what the dax device can do..... Copious amounts of unused time are things I don't have, unfortunately. Only having 7 fingers to type with right now doesn't help, either. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
