Re: [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christian Brauner <christian.brauner@xxxxxxxxxx>
Subject: Re: [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags
From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 06 Mar 2020 14:43:42 +0000
Cc: dhowells@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, metze@xxxxxxxxx, cyphar@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20200306135632.j7kidnqm3edji6cz@wittgenstein>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Christian Brauner <christian.brauner@xxxxxxxxxx> wrote:

> > +	if (flags & O_NOFOLLOW)
> > +		lookup_flags &= ~LOOKUP_FOLLOW;
> 
> Odd change. But I guess you're doing it for the sake of consistency
> because of how you treat NO_TERMINAL_SYMLINKS below.

Not really.  The default is to follow.  Both remove the LOOKUP_FOLLOW flag and
neither set it.

David

References:
- Re: [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags
  - From: Christian Brauner
- [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags
  - From: David Howells

Prev by Date: Re: KASAN: use-after-free Read in percpu_ref_switch_to_atomic_rcu
Next by Date: Re: Have RESOLVE_* flags superseded AT_* flags for new syscalls?
Previous by thread: Re: [RFC][PATCH] Mark AT_* path flags as deprecated and add missing RESOLVE_ flags
Next by thread: [PATCH] mnt: add support for non-rootfs initramfs
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]