Re: [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pankaj Gupta <pankaj.gupta.linux@xxxxxxxxx>
Subject: Re: [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 4 Mar 2020 08:16:37 -0800
Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, hch@xxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, david@xxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <CAM9Jb+gJWH_bC-9fgGdeP5LaSVjJ3JgTnjBxpRJMfe6vbTPOTA@mail.gmail.com>

On Sat, Feb 29, 2020 at 09:04:00AM +0100, Pankaj Gupta wrote:
> > +       phys_addr_t pmem_off = sector * 512 + pmem->data_offset;
> 
> minor nit,  maybe 512 is replaced by macro? Looks like its used at multiple
> places, maybe can keep at is for now.

That would be the existing SECTOR_SIZE macro.

References:
- [PATCH v6 0/6] dax/pmem: Provide a dax operation to zero page range
  - From: Vivek Goyal
- [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem
  - From: Vivek Goyal
- Re: [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem
  - From: Pankaj Gupta

Prev by Date: [PATCH] vfs: Remove duplicated d_mountpoint check in __is_local_mountpoint
Next by Date: Re: [RFC][PATCHSET] sanitized pathwalk machinery (v3)
Previous by thread: Re: [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem
Next by thread: Re: [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]