On Friday 25 July 2008 03:59, Christoph Hellwig wrote: > On Fri, Jul 25, 2008 at 01:17:11AM +1000, Nick Piggin wrote: > > Hi, I have some questions about your patch in -mm > > > > vfs-pagecache-usage-optimization-onpagesize=blocksize-environment.patch > > > > I have no particular problem with something like this, but leaving the > > implementation details aside for the moment, can we discuss the > > justification for this? > > > > Are there significant numbers of people using block size < page size in > > situations where performance is important and significantly improved by > > this patch? Can you give any performance numbers to illustrate perhaps? > > With XFS lots of people use 4k blocksize filesystems on ia64 systems > with 16k pages, so an optimization like this would be useful. > > But as mentioned in one of your previous comments I'd rather prefer > a readpage interface chaneg to deal with this. Yeah... actually if it is a nice win I don't mind too much to go with this API to start with, and consolidate with readpage later. Readpage I am thinking about making a few other changes for it as well, so I am happy to look at folding in this partially-uptodate API with it as well. If we just get some numbers (maybe SGI can help out?), I'm happy enough with this approach. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
