On Wed, Feb 12, 2020 at 07:29:00PM +0000, Mark Brown wrote: > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1b6e8955c597..5d5b0321da0b 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -63,7 +63,11 @@ extern int elf_coredump_extra_notes_size(void); > extern int elf_coredump_extra_notes_write(struct coredump_params *cprm); > #endif > > -/* NT_GNU_PROPERTY_TYPE_0 header */ > +/* > + * NT_GNU_PROPERTY_TYPE_0 header: > + * Keep this internal until/unless there is an agreed UAPI definition. > + * pr_type values (GNU_PROPERTY_*) are public and defined in the UAPI header. > + */ > struct gnu_property { > u32 pr_type; > u32 pr_datasz; I think this hunk should be in patch 1. -- Kees Cook