On 2020/02/25 5:19, Christoph Hellwig wrote: > On Mon, Feb 24, 2020 at 01:48:48PM +0000, Damien Le Moal wrote: >> >> The main problem with allowing IOCB_NOWAIT is that for an application that sends >> multiple write AIOs with a single io_submit(), all write AIOs after one that is >> failed with -EAGAIN will be failed with -EINVAL (not -EIO !) since they will >> have an unaligned write offset. I am wondering if that is really a problem at >> all since the application can catch the -EAGAIN and -EINVAL, indicating that the >> write stream was stopped. So maybe it is reasonable to simply allow IOCB_NOWAIT ? > > I don't think supporting IOCB_NOWAIT with current zonefs is very useful. > It will be very useful once Zone Append is supported. > > But more importantly my patch fixes a bug in the current zonefs > implementation. We need to fix that before 5.6 is released. Any > additional functionaity can still come later if we think that it is > useful. > OK. Fair enough. I will apply your patch. Thanks ! -- Damien Le Moal Western Digital Research
