On Wed, Feb 19, 2020 at 01:00:51PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > > ext4 and f2fs have duplicated the guts of the readahead code so > they can read past i_size. Instead, separate out the guts of the > readahead code so they can call it directly. I don't like this, but then I like the horrible open coded versions even less.. Can you add a do not use for new code comment to the function as well? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
