Ok, so far I haven't seen anything bad. But I keep noticing these odd
stylistic things...
On Sat, Feb 22, 2020 at 5:22 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> - return step_into(nd, flags, dentry, inode, seq);
> + err = step_into(nd, flags, dentry, inode, seq);
> + if (!err)
> + return NULL;
> + else if (err > 0)
> + return get_link(nd);
> + else
> + return ERR_PTR(err);
> }
What?
Those "else" statements make no sense.
Each if-statement has a "return" in it. It's done. The else part is
not adding anything but confusion.
IOW, this should be
if (!err)
return NULL;
if (err > 0)
return get_link(nd);
return ERR_PTR(err);
with not an 'else' in sight.
Linus
