On Sat, Feb 22, 2020 at 5:16 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > + > +discard2: > + namespace_unlock(); > +discard1: > + inode_unlock(dentry->d_inode); > +discard: > /* remove m from any expiration list it may be on */ Would you mind re-naming those labels? I realize that the numbering may help show that the error handling is done in the reverse order, but I bet that a nice name could so that too. Linus