On 6:02 17/02, Christoph Hellwig wrote: > On Mon, Feb 17, 2020 at 07:44:17AM -0600, Goldwyn Rodrigues wrote: > > > Haven't we traditionally failed direct I/O syscalls that don't fully > > > complete and never supported short writes (or reads)? > > > > Yes, but I think that decision should be with the filesystem what to do > > with it and not the iomap layer. > > But then you also need to fix up the existing callers to do the > conversion. The error returned is set in iomap_dio_complete() which happens after. I checked all instances and the the only place which uses written in direct I/O is ext4. I will put in the change. Thanks! -- Goldwyn
