Hi Amir, I love your patch! Yet something to improve: [auto build test ERROR on 11a48a5a18c63fd7621bb050228cebf13566e4d8] url: https://github.com/0day-ci/linux/commits/Amir-Goldstein/Fanotify-event-with-name-info/20200219-160517 base: 11a48a5a18c63fd7621bb050228cebf13566e4d8 config: i386-tinyconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): In file included from fs///attr.c:15:0: include/linux/fsnotify.h: In function 'fsnotify_dentry': >> include/linux/fsnotify.h:52:18: warning: passing argument 1 of 'fsnotify_parent' makes integer from pointer without a cast [-Wint-conversion] fsnotify_parent(dentry, mask, inode, FSNOTIFY_EVENT_INODE); ^~~~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: expected '__u32 {aka unsigned int}' but argument is of type 'struct dentry *' static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: >> include/linux/fsnotify.h:52:26: warning: passing argument 2 of 'fsnotify_parent' makes pointer from integer without a cast [-Wint-conversion] fsnotify_parent(dentry, mask, inode, FSNOTIFY_EVENT_INODE); ^~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: expected 'const void *' but argument is of type '__u32 {aka unsigned int}' static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: include/linux/fsnotify.h:52:32: warning: passing argument 3 of 'fsnotify_parent' makes integer from pointer without a cast [-Wint-conversion] fsnotify_parent(dentry, mask, inode, FSNOTIFY_EVENT_INODE); ^~~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: expected 'int' but argument is of type 'struct inode *' static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: >> include/linux/fsnotify.h:52:2: error: too many arguments to function 'fsnotify_parent' fsnotify_parent(dentry, mask, inode, FSNOTIFY_EVENT_INODE); ^~~~~~~~~~~~~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: declared here static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: include/linux/fsnotify.h: In function 'fsnotify_file': include/linux/fsnotify.h:68:24: warning: passing argument 1 of 'fsnotify_parent' makes integer from pointer without a cast [-Wint-conversion] ret = fsnotify_parent(path->dentry, mask, path, FSNOTIFY_EVENT_PATH); ^~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: expected '__u32 {aka unsigned int}' but argument is of type 'struct dentry * const' static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: include/linux/fsnotify.h:68:38: warning: passing argument 2 of 'fsnotify_parent' makes pointer from integer without a cast [-Wint-conversion] ret = fsnotify_parent(path->dentry, mask, path, FSNOTIFY_EVENT_PATH); ^~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: expected 'const void *' but argument is of type '__u32 {aka unsigned int}' static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: include/linux/fsnotify.h:68:44: warning: passing argument 3 of 'fsnotify_parent' makes integer from pointer without a cast [-Wint-conversion] ret = fsnotify_parent(path->dentry, mask, path, FSNOTIFY_EVENT_PATH); ^~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: expected 'int' but argument is of type 'const struct path *' static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ In file included from fs///attr.c:15:0: include/linux/fsnotify.h:68:8: error: too many arguments to function 'fsnotify_parent' ret = fsnotify_parent(path->dentry, mask, path, FSNOTIFY_EVENT_PATH); ^~~~~~~~~~~~~~~ In file included from include/linux/fsnotify.h:15:0, from fs///attr.c:15: include/linux/fsnotify_backend.h:543:19: note: declared here static inline int fsnotify_parent(__u32 mask, const void *data, int data_type) ^~~~~~~~~~~~~~~ vim +/fsnotify_parent +52 include/linux/fsnotify.h 40 41 /* 42 * Simple wrappers to consolidate calls fsnotify_parent()/fsnotify() when 43 * an event is on a file/dentry. 44 */ 45 static inline void fsnotify_dentry(struct dentry *dentry, __u32 mask) 46 { 47 struct inode *inode = d_inode(dentry); 48 49 if (S_ISDIR(inode->i_mode)) 50 mask |= FS_ISDIR; 51 > 52 fsnotify_parent(dentry, mask, inode, FSNOTIFY_EVENT_INODE); 53 fsnotify(inode, mask, inode, FSNOTIFY_EVENT_INODE, NULL, 0); 54 } 55 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
