On Tue, Feb 18, 2020 at 08:10:52PM +0300, Kirill A. Shutemov wrote: > Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> Thanks > > +#if defined(CONFIG_HIGHMEM) && defined(CONFIG_TRANSPARENT_HUGEPAGE) > > +void zero_user_segments(struct page *page, unsigned start1, unsigned end1, > > + unsigned start2, unsigned end2); > > +#else /* !HIGHMEM || !TRANSPARENT_HUGEPAGE */ > > This is a neat trick. I like it. > > Although, it means non-inlined version will never get tested :/ I worry about that too, but I don't really want to incur the overhead on platforms people actually use.