On 20/2/18 18:07, Mauro Carvalho Chehab wrote: > Em Tue, 18 Feb 2020 09:21:51 +0800 > Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx> escreveu: > >> On 20/2/18 00:11, Mauro Carvalho Chehab wrote: > >>> @@ -96,14 +101,19 @@ operation. If the lock succeeds, you'll get an fd. >>> open(2) with O_CREAT to ensure the resource inode is created - dlmfs does >>> not automatically create inodes for existing lock resources. >>> >>> +============ =========================== >>> Open Flag Lock Request Type >>> ---------- ----------------- >> >> Better to remove the above line. >> >>> +============ =========================== >>> O_RDONLY Shared Read >>> O_RDWR Exclusive >>> +============ =========================== >>> >>> + >>> +============ =========================== >>> Open Flag Resulting Locking Behavior >>> ---------- -------------------------- >> >> Ditto. > > Ok. So, I guess we can just merge the two tables into one, like: > > ============ ================= > O_RDONLY Shared Read > O_RDWR Exclusive > O_NONBLOCK Trylock operation > ============ ================= > > Right? > I think they should be in different section. The first two are lock level, while the last is lock behavior. Thanks, Joseph
