Looks good modulo some nitpicks below: Reviewed-by: Christoph Hellwig <hch@xxxxxx> > + * Context: Any context. Does this add any value for a trivial helper like this? > + * Return: The number of filesystem blocks covered by this page. > + */ > +static inline > +unsigned int i_blocks_per_page(struct inode *inode, struct page *page) static inline unisnged int i_blocks_per_page(struct inode *inode, struct page *page)