Re: [PATCH] bootconfig: Use parse_args() to find bootconfig and '--'

[Steven Rostedt <rostedt@xxxxxxxxxxx>]

On Fri, 7 Feb 2020 19:26:32 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

>  static void __init setup_boot_config(const char *cmdline)
>  {
> +	static char tmp_cmdline[COMMAND_LINE_SIZE] __initdata;
>  	u32 size, csum;
>  	char *data, *copy;
>  	const char *p;

I have a v2 of this patch that removes the variable "p" as I now get an
unused variable because of it.

-- Steve


>  	u32 *hdr;
>  	int ret;
>  
> -	p = strstr(cmdline, "bootconfig");
> -	if (!p || (p != cmdline && !isspace(*(p-1))) ||
> -	    (p[10] && !isspace(p[10])))
> +	strlcpy(tmp_cmdline, boot_command_line, COMMAND_LINE_SIZE);
> +	parse_args("bootconfig", tmp_cmdline, NULL, 0, 0, 0, NULL,
> +		   bootconfig_params);
> +
> +	if (!bootconfig_found)
>  		return;