Re: [PATCH] exportfs: fix handling of rename race in reconnect_one()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 06, 2020 at 10:22:21PM +0200, Amir Goldstein wrote:
> On Mon, Jan 27, 2020 at 11:18 PM J. Bruce Fields <bfields@xxxxxxxxxx> wrote:
> >
> > On Mon, Jan 27, 2020 at 08:38:00PM +0200, Amir Goldstein wrote:
> > > > > Commit 909e22e05353 ("exportfs: fix 'passing zero to ERR_PTR()'
> > > > > warning") changes this behavior from always returning success,
> > > > > regardless if dentry was reconnected by somoe other task, to always
> > > > > returning a failure.
> > > >
> > > > I wonder whether it might be safest to take the out_reconnected case on
> > > > any error, not just -ENOENT.
> > > >
> > >
> > > I wondered that as well, but preferred to follow the precedent.
> >
> > I can live with that.
> 
> Will you take this patch through your tree,
> or do you want me to re-post to Al?

If Al wants to delegate exportfs/ patches to nfsd maintainers that's OK
by me, but in the past I think it's always him that's taken them.

> With your Reviewed-by?

That'd be fine.  Thanks!

--b.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux