Re: [PATCH] fuse: Allow parallel DIO reads and check NOWAIT case for DIO writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 02, 2020 at 10:25:43PM +0100, Bernd Schubert wrote:
> 
> 
> > @@ -1518,6 +1525,9 @@ static ssize_t fuse_direct_read_iter(struct kiocb *iocb, struct iov_iter *to)
> >  
> >  		res = __fuse_direct_read(&io, to, &iocb->ki_pos);
> >  	}
> > +	inode_unlock_shared(inode);
> > +
> > +	file_accessed(iocb->ki_filp);
> 
> 
> Shouldn't the file_accessed() in different patch, with a description? It
> looks totally unrelated to locking?
>
Thanks for your remind! file_accessed() is used to update atime for
every direct read, it's totally unrelated to locking. I will separate
it to another patch.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux