On Thu, Jan 30, 2020 at 03:38:25PM +0000, Al Viro wrote: > On Thu, Jan 30, 2020 at 03:45:20PM +0100, Christian Brauner wrote: > > > - nd->total_link_count++; > > > - if (nd->total_link_count >= 40) > > > + if (count && *count++ >= 40) > > > > He, side-effects galore. :) > > Isn't this incrementing the address but you want to increment the > > counter? > > Seems like this should be > > > > if (count && (*count)++ >= 40) > > Nice catch; incidentally, it means that usual testsuites (xfstests, > LTP) are missing the automount loop detection. Hmm... Fix folded and pushed (the series in #next.namei now, on top of #work.openat2 + #fixes)
