On Tue, 1 Jul 2008 12:03:50 +0200 Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> wrote: > I think since XXX_pipe_fops are only used in this file, > just explaining this in the comment would be enough. no, a comment is only needed when the code is unobvious. Make the code obvious and we don't need a comment. As Christoph pointed out, open-coding shared_read_fops everywhere might make sense too. It'd make it harder to unshare them later on, but that's pretty improbable. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
