Re: [PATCH v9 1/2] fs: New zonefs file system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020/01/28 10:28, Linus Torvalds wrote:
> On Mon, Jan 27, 2020 at 5:26 PM Damien Le Moal <Damien.LeMoal@xxxxxxx> wrote:
>>
>> Yes, good catch. Furthermore, since this array is used only in
>> zonefs_create_zgroup(), I moved its declaration on-stack in that function.
> 
> What?
> 
> Making it _local_ to that function makes sense, but not on stack.
> Please keep it "static const char *[]" so that it isn't copied onto
> the stack.

Done. Thanks.

> 
>                Linus
> 
-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux