Re: [fuse-devel] avoiding atime invalidation with mount -o noatime (instead of just -o ro)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2020 at 11:56 PM Robert Byrnes <byrnes@xxxxxxxxxxxxxxx> wrote:
>
> The fuse module invalidates the atime after any operation (like readlink)
> that might change it, using this function (in fs/fuse/dir.c) ...
>
> /**
>  * Mark the attributes as stale due to an atime change.  Avoid the
> invalidate if
>  * atime is not used.
>  */
> void fuse_invalidate_atime(struct inode *inode)
> {
>         if (!IS_RDONLY(inode))
>                 WRITE_ONCE(get_fuse_inode(inode)->inval_atime, 1);
> }
>
> Shouldn't that be IS_NOATIME instead of IS_RDONLY?

It would work if we also added an INIT flag (e.g. FUSE_NOATIME) which
would set SB_NOATIME on the fuse superblock.

The current per-mount "noatime" option doesn't work exactly because
it's per-mount and we cannot determine if all mounts of a given
superblock have this flag set.

Thanks,
Miklos



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux