Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 17 January 2020 13:22:27 Namjae Jeon wrote:
> > > +config EXFAT_DEFAULT_IOCHARSET
> > > +	string "Default iocharset for exFAT"
> > > +	default "utf8"
> > > +	depends on EXFAT_FS
> > > +	help
> > > +	  Set this to the default input/output character set you'd
> > > +	  like exFAT to use. It should probably match the character set
> > > +	  that most of your exFAT filesystems use, and can be overridden
> > > +	  with the "iocharset" mount option for exFAT filesystems.
> > 
> > Hello! This description is incorrect. iocharset option specify what
> > character set is expected by VFS layer and not character set used by exFAT
> > filesystem. exFAT filesystem always uses UTF-16 as this is the only
> > allowed by exFAT specification.
> Hi Pali,
> 
> Could you please review updated description ?
> 
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> index 9eeaa6d06..f2b0cf2c1 100644
> --- a/fs/exfat/Kconfig
> +++ b/fs/exfat/Kconfig
> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
>         default "utf8"
>         depends on EXFAT_FS
>         help
> -         Set this to the default input/output character set you'd
> -         like exFAT to use. It should probably match the character set
> -         that most of your exFAT filesystems use, and can be overridden
> -         with the "iocharset" mount option for exFAT filesystems.
> +         Set this to the default input/output character set to use for
> +         converting between the encoding is used for user visible filename and
> +         UTF-16 character that exfat filesystem use. and can be overridden with
> +         the "iocharset" mount option for exFAT filesystems.

Hello! This is much better. Fine for me.

-- 
Pali Rohár
pali.rohar@xxxxxxxxx



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux