On Mon, Jan 06, 2020 at 01:11:17PM -0500, Vivek Goyal wrote:
> Looks like nobody is using fs_dax_get_by_host() except fs_dax_get_by_bdev()
> and it can easily use dax_get_by_host() instead.
>
> IIUC, fs_dax_get_by_host() was only introduced so that one could compile
> with CONFIG_FS_DAX=n and CONFIG_DAX=m. fs_dax_get_by_bdev() achieves
> the same purpose and hence it looks like fs_dax_get_by_host() is not
> needed anymore.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Hi Dan,
Ping for this patch. How does it look to you. If you don't have concerns,
can you please take it in your tree.
Thanks
Vivek
> ---
> drivers/dax/super.c | 2 +-
> include/linux/dax.h | 10 ----------
> 2 files changed, 1 insertion(+), 11 deletions(-)
>
> Index: rhvgoyal-linux-fuse/drivers/dax/super.c
> ===================================================================
> --- rhvgoyal-linux-fuse.orig/drivers/dax/super.c 2020-01-03 11:19:57.616186062 -0500
> +++ rhvgoyal-linux-fuse/drivers/dax/super.c 2020-01-03 11:20:08.941186062 -0500
> @@ -61,7 +61,7 @@ struct dax_device *fs_dax_get_by_bdev(st
> {
> if (!blk_queue_dax(bdev->bd_queue))
> return NULL;
> - return fs_dax_get_by_host(bdev->bd_disk->disk_name);
> + return dax_get_by_host(bdev->bd_disk->disk_name);
> }
> EXPORT_SYMBOL_GPL(fs_dax_get_by_bdev);
> #endif
> Index: rhvgoyal-linux-fuse/include/linux/dax.h
> ===================================================================
> --- rhvgoyal-linux-fuse.orig/include/linux/dax.h 2020-01-03 11:20:05.603186062 -0500
> +++ rhvgoyal-linux-fuse/include/linux/dax.h 2020-01-03 11:20:08.942186062 -0500
> @@ -129,11 +129,6 @@ static inline bool generic_fsdax_support
> sectors);
> }
>
> -static inline struct dax_device *fs_dax_get_by_host(const char *host)
> -{
> - return dax_get_by_host(host);
> -}
> -
> static inline void fs_put_dax(struct dax_device *dax_dev)
> {
> put_dax(dax_dev);
> @@ -160,11 +155,6 @@ static inline bool generic_fsdax_support
> return false;
> }
>
> -static inline struct dax_device *fs_dax_get_by_host(const char *host)
> -{
> - return NULL;
> -}
> -
> static inline void fs_put_dax(struct dax_device *dax_dev)
> {
> }
