On 01/10/20 14:42, Peter Zijlstra wrote:
> On Thu, Jan 09, 2020 at 01:00:58PM +0000, Qais Yousef wrote:
> > On 01/08/20 14:44, Peter Zijlstra wrote:
>
> > > Did cpu_uclamp_write() forget to check for input<0 ?
> >
> > Hmm just tried that and it seems so
> >
> > # echo -1 > cpu.uclamp.min
> > # cat cpu.uclamp.min
> > 42949671.96
> >
> > capacity_from_percent(); we check for
> >
> > 7301 if (req.percent > UCLAMP_PERCENT_SCALE) {
> > 7302 req.ret = -ERANGE;
> > 7303 return req;
> > 7304 }
> >
> > But req.percent is s64, maybe it should be u64?
>
> if ((u64)req.percent > UCLAMP_PERCENT_SCALE)
>
> should do, I think.
Okay I'll send a separate fix for that.
Cheers
--
Qais Yousef
