> On Thursday 02 January 2020 16:20:33 Namjae Jeon wrote: > > This adds the implementation of nls operations for exfat. > > Hello! In whole patch series are different naming convention for > nls/Unicode related terms. E.g. uni16s, utf16s, nls, vfsname, ... > > Could this be fixed, so it would be unambiguously named? "uni16s" name is > misleading as Unicode does not fit into 16byte type. > > Based on what is in nls.h I would propose following names: > > * unicode_t *utf32s always for strings in UTF-32/UCS-4 encoding (host > endianity) (or "unicode_t *unis" as this is the fixed-width encoding > for all Unicode codepoints) > > * wchar_t *utf16s always for strings in UTF-16 encoding (host endianity) > > * u8 *utf8s always for strings in UTF-8 encoding > > * wchar_t *ucs2s always for strings in UCS-2 encoding (host endianity) > > Plus in the case you need to work with UTF-16 or UCS-2 in little endian, > add appropriate naming suffixes. > > And use e.g. "vfsname" (char * OR unsigned char * OR u8 *) like you > already have on some places for strings in iocharset= encoding. Will rename them on v10. Thanks!
