On Thu, Jan 09, 2020 at 10:05:24AM +0800, Ming Lei wrote: > OK, will do that. > > > > > > + if (bio_data_dir(bio) != READ) > > > + goto exit; > > > > This really should check the passed in op for REQ_OP_READ directly instead > > of just the direction on the potentially not fully set up bio. > > It has been addressed in: > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=block-5.5&id=802ca0381befe29ba0783e08e3369f9e87ef9d0d Well, it fixes the bug introduced. But it still uses bio_data_dir instead of the explicit REQ_OP_READ check, and still uses a calling convention that leads to such errors.
