Ritesh - I just loaded your patch on top of 5.5-rc4 and it looks fine to me and xfstests :-) ... I pointed ftrace at the orangefs function you modified while xfstests was running, and it got called about a jillion times... -Mike On Wed, Jan 1, 2020 at 5:53 AM Ritesh Harjani <riteshh@xxxxxxxxxxxxx> wrote: > > Al, any comments? > Resending this after adding Reviewed-by/Acked-by tags. > > > From previous version:- > Matthew Wilcox in [1] suggested that it will be a good idea > to define some missing API instead of directly using i_rwsem in > filesystems drivers for lock/unlock/downgrade purposes. > > This patch does that work. No functionality change in this patch. > > After this there are only lockdep class of APIs at certain places > in filesystems which are directly using i_rwsem and second is XFS, > but it seems to be anyway defining it's own xfs_ilock/iunlock set > of APIs and 'iolock' naming convention for this lock. > > [1]: https://www.spinics.net/lists/linux-ext4/msg68689.html > > Ritesh Harjani (1): > fs: Use inode_lock/unlock class of provided APIs in filesystems > > fs/btrfs/delayed-inode.c | 2 +- > fs/btrfs/ioctl.c | 4 ++-- > fs/ceph/io.c | 24 ++++++++++++------------ > fs/nfs/io.c | 24 ++++++++++++------------ > fs/orangefs/file.c | 4 ++-- > fs/overlayfs/readdir.c | 2 +- > fs/readdir.c | 4 ++-- > include/linux/fs.h | 21 +++++++++++++++++++++ > 8 files changed, 53 insertions(+), 32 deletions(-) > > -- > 2.21.0 >
