On Wed, Dec 25, 2019 at 9:19 PM kbuild test robot <lkp@xxxxxxxxx> wrote: > > Hi Yafang, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v5.5-rc3 next-20191220] > [cannot apply to mmotm/master] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Yafang-Shao/protect-page-cache-from-freeing-inode/20191225-193636 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 46cf053efec6a3a5f343fead837777efe8252a46 > config: i386-tinyconfig (attached as .config) > compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > In file included from include/linux/swap.h:9:0, > from include/linux/suspend.h:5, > from arch/x86/kernel/asm-offsets.c:13: > >> include/linux/memcontrol.h:872:23: error: conflicting types for 'memcg' > struct inode *memcg) > ^~~~~ > include/linux/memcontrol.h:871:63: note: previous definition of 'memcg' was here > static inline bool memcg_can_reclaim_inode(struct mem_cgroup *memcg, > ^~~~~ > make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > make[2]: Target '__build' not remade because of errors. > make[1]: *** [prepare0] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [sub-make] Error 2 > 9 real 4 user 3 sys 93.40% cpu make prepare > > vim +/memcg +872 include/linux/memcontrol.h > > 870 > 871 static inline bool memcg_can_reclaim_inode(struct mem_cgroup *memcg, > > 872 struct inode *memcg) > 873 { > 874 return true; > 875 } > 876 > Will fix this build error (when CONFIG_MEMCG_KMEM is not set) in next version, thanks kbuild test robot. Thanks Yafang