On 12/20/19 4:33 PM, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Currently when the call to percpu_ref_init fails ctx->file_data is > set to null and because there is a missing return statement the > following statement dereferences this null pointer causing an oops. > Fix this by adding the missing -ENOMEM return to avoid the oops. Nice, thanks! I'm guessing I didn't have the necessary magic debug options to allow failure injection for failing. -- Jens Axboe